search

NanoAdblocker / NanoCore

An adblocker
GNU General Public License v3.0
463 stars 22 forks source link

Prepare for 1.25.2 #309

Closed jspenguin2017 closed 4 years ago

jspenguin2017 commented 4 years ago

Reviewed until https://github.com/gorhill/uBlock/commit/04021424d0d1bd4552146e9425430e088580088e

Update: Last commit for this version reviewed

jspenguin2017 commented 4 years ago

TODO:

https://github.com/gorhill/uBlock/commit/2ac288397ca599692a4450bfdf511453bfa03bb7

How does it handle immediate advanced settings in this case?

https://github.com/gorhill/uBlock/commit/3621792f1635e933667b12cc7c830020fb1c81c0

Looks like it is handled asynchronously, not sure how well this is going to work.

jspenguin2017 commented 4 years ago

TODO:

https://github.com/gorhill/uBlock/commit/84635ad38d1edf417f52cc52d6f66d46589036c4

The filter list now supports HTTPS, can be added back to the assets manifest.

Update: Done

jspenguin2017 commented 4 years ago

TODO:

https://github.com/gorhill/uBlock/commit/8780ef24136d20d6c64225acf5289a4b383862af

jspenguin2017 commented 4 years ago

I don't feel very confident about this update, the LocalStorage changes feel rushed.

I don't see any important changes, so I'll wait a bit.

jspenguin2017 commented 4 years ago

Going to sync 1.26.0 directly.