Prepare for 1.27.2 - Githubissues

jspenguin2017 commented 4 years ago

Reviewed until: https://github.com/gorhill/uBlock/commit/35091e6d877fa1c684a7630506f6aad692dfb5b7

jspenguin2017 commented 4 years ago

TODO:

(many commits)

Verify that customized whitelist highlighting is still working properly.

Verify that the advanced settings page is still working properly.

Verify that the about page is still rendering properly.

Verify that the dashboard is working properly in mobile mode.

Verify that the popup, logger, and dashboard are working properly in incognito mode.

Verify that FontAwesome is still working properly (in the popup and the dashboard).

Verify that background color and contrast look good.

Verify that Nano Editor is behaving properly when the browser window is resized.

Also double-check to make sure the redesigned dashboard and popup are working as expected in general.

There are a lot of changes, to be safe, run through the extended checklist: https://github.com/NanoAdblocker/NanoCore2#version-update-extended-checklist

Watch out, 1p-filters.html and asset-viewer.html have changed:

https://github.com/gorhill/uBlock/commit/0662767dd62731320473e9c96a17077145a00610#diff-6ef3f8b01ddac4fee83c2d44d4f5f035 https://github.com/gorhill/uBlock/commit/5bee33253f4549df7853823fba268d2003d120ae#diff-6ef3f8b01ddac4fee83c2d44d4f5f035 https://github.com/gorhill/uBlock/commit/fe94aa331ac2cfbb1ef2e350f7d50fb061ecb7bc#diff-6ef3f8b01ddac4fee83c2d44d4f5f035

https://github.com/gorhill/uBlock/commit/0662767dd62731320473e9c96a17077145a00610#diff-c6081be1a3096dc599ff4d17f8c1741e

Update: Everything looks good.

jspenguin2017 commented 4 years ago

TODO:

https://github.com/gorhill/uBlock/commit/bf2d38ccf3271fccb3a343f74a8ac5708d7deb35

Update: Done.

jspenguin2017 commented 4 years ago

TODO:

https://github.com/gorhill/uBlock/commit/4687c60bf9cec5b68e5a007d740af93f4119a79e

A cache buster is no longer supplied for background updates, this can cause problems when the remote server is misconfigured (sending a large max-age for Cache-Control header).

Update: Moved to another issue: https://github.com/NanoAdblocker/NanoCore/issues/330

jspenguin2017 commented 4 years ago

TODO:

https://github.com/gorhill/uBlock/commit/1de0e820b87fdd3717b9f2653baaa7a934075055

Check to make sure Nano Filters, Nano Contrib, and Nano Defender Integration are not affected.

Update: Done.

jspenguin2017 commented 4 years ago

TODO:

https://github.com/gorhill/uBlock/commit/0bcf04d3dda2065a6a16c86b05fa3c95c8918ae9 https://github.com/gorhill/uBlock/commit/54b68ebd942668a55bc53237e55be8d846ad8770

Check to make sure the changes to 1p-filters do not break Nano Editor.

Update: Done.

jspenguin2017 commented 4 years ago

TODO:

https://github.com/gorhill/uBlock/commit/08be3a055839687fa854f2c7c6e5562dbabc6206

Update: Done.

jspenguin2017 commented 4 years ago

Upstream bumped version to update assets. The specific issue about gstaticadssl does not occur with current assets bundled with the latest Nano release, so I don't think I need to do an emergency release just to update assets.

jspenguin2017 commented 4 years ago

TODO:

https://github.com/gorhill/uBlock/commit/0afe7c2231f9bbafe30c71eb8a7cabdc8e61b111#diff-5c490989a776cfd759127df7a1241973 https://github.com/gorhill/uBlock/commit/98f19facec7ad58c14331bd74670e5022d2ccdfe#diff-5c490989a776cfd759127df7a1241973 https://github.com/gorhill/uBlock/commit/65d9e3f8203960a96e05b4e4c945c5a820136205

Check to make sure the animation is not intrusive.

Edit: This should be moved to the extended checklist.

Update: Animation removed: https://github.com/gorhill/uBlock/commit/104a1af6c279392e7c1f17397e35dc6f3b11d5b4

jspenguin2017 commented 4 years ago

TODO:

https://github.com/gorhill/uBlock/commit/01ab072f07f8f0455216d2e1c24d8376c384fbe0

Add links to Nano's repositories and contributor lists as appropriate.

Update: Done.

jspenguin2017 commented 4 years ago