search

NanoAdblocker / NanoFilters

Script snippets and filters
GNU General Public License v3.0
127 stars 28 forks source link

[Anti-adblock] uploadship.com #405

Closed avoxismith closed 5 years ago

avoxismith commented 5 years ago

URLs where this issue occurs (Required)

https://uploadship.com ### Screenshots (Required) ### Screenshot of console (Required, press `F12` to open the console) ### Describe the issue (Optional if obvious) I have Nano Adblocker installed as an addon with the latest Firefox 69.0. I also have Nano defender and nano filter list enabled. But still Nano adblocker is getting detected. It stops getting detected if I enable inline scripts, but that closes down some other functionality. ### Reproduction Steps (Optional if trivial)

Anything else you believe to be useful (Optional)

Environment (Required)

Your filter lists (Required)

Your custom filters (Required if you have any)

Your other extensions (Required if you have any)

liamengland1 commented 5 years ago

Need a better test URL. Please provide the specific link.

avoxismith commented 5 years ago

Hi, It is a upload service and I have uploaded few files to test the adblock features. The test url is : https://www.uploadship.com/496e3647cb78da95

Once you open it on your browser, Adblock detection pops up as an error. If you want you can upload a file and test it out. I have attached screenshots.

avoxismith commented 5 years ago

I don't know why, but the screenshot didn't get attached - I provided an imgur url. https://imgur.com/lfQQxVL

avoxismith commented 5 years ago

This is the script that is firing the Adblock detection:

jspenguin2017 commented 5 years ago

I can't seem to reproduce it. Do you have the latest filters?

jspenguin2017 commented 5 years ago

Was able to reproduce after a few refreshes. @okiehsch race condition?

avoxismith commented 5 years ago

Yes, I do have the latest filters. I have purged cache and updated all of them.

okiehsch commented 5 years ago

Does it work if you add

uploadship.com##+js(abort-current-inline-script, document.getElementById, adblock)

to your filter list?

okiehsch commented 5 years ago

I get occasionally redirected with that filter but 

uploadship.com##+js(acis, document.getElementById, adblock)
uploadship.com##+js(std, adblock)

seems to work consistently on my end.

okiehsch commented 5 years ago

@jspenguin2017 the same issue has been opened at uAssets. I will reference https://github.com/uBlockOrigin/uAssets/issues/6370 in the fix.

avoxismith commented 5 years ago

@okiehsch It doesn't work, moreover I tried these following filters:

uploadship.com##+js(abort-current-inline-script, document.getElementById, bannerad) uploadship.com##+js(abort-current-inline-script.js, document.getElementById, style.display) @@||uploadship.com/showads.js$script,first-party uploadship.com##^script:has-text(e55318040a8544bda8d0508d4544bee5)

okiehsch commented 5 years ago

https://github.com/uBlockOrigin/uAssets/commit/032383f91494cbfc5e1278bbddec50875b29441b https://github.com/uBlockOrigin/uAssets/commit/2058e4aed812b5cd90f914f8d14c991396452224

avoxismith commented 5 years ago

@okiehsch Added the changes to my filter list

uBlockOrigin/uAssets@032383f uBlockOrigin/uAssets@2058e4a

Still no luck, I have purged all the filter cache and updated them. Still the page redirects toAdblock error message.

okiehsch commented 5 years ago

Hm, I have allowed everything the site checks, so I don't know why it does not work for you. It does work on my end.

avoxismith commented 5 years ago

@okiehsch Thnx for your effort, really appreciate it! So, I went ahead and created a fresh Firefox profile without private mode and added Nano Adblocker and tried the above mentioned filter list and it worked, but the moment I turned on private mode the filters stopped working and the Adblock message came up. So, either the filter list stops working in private mode or the Anti-Adblock script detects private moode and maybe has added protection.

okiehsch commented 5 years ago

but the moment I turned on private mode the filters stopped working and the Adblock message came up.

The site checks if certain requests are allowed and if it thinks they are blocked the users get the anti-adblock message. The Firefox private mode blocks requests before uBO can allow them. There is no way for uBO to fix that. You have to disable private mode if you want to use uploadship.com.

avoxismith commented 5 years ago

@okiehsch Thnx a lot! No issues, I will try to use Firefox containers I think the issue is now resolved. Amazing, the prompt resolutions from you guys!! Keep up the good work. BTW is there an option for donation/contribution, coz I didn't see that on the homepage.