search

NanoComp / libctl

Guile-based library implementing flexible control files for scientific simulations
GNU General Public License v2.0
18 stars 22 forks source link

code duplicated in ctl.h and ctl-math.h #5

Closed HomerReid closed 7 years ago

HomerReid commented 7 years ago

It looks like the new file ctl-math.c is a verbatim extraction of lines 119-399 from file ctl.c, intended to allow that code to be linked with the new guile-independent libctlgeom.

However, those lines are still present in ctl.c, which causes link errors when building libctl, i.e. 

/home/homer/work/Simpetus/libctl/src/ctl-math.c:237: multiple definition of `cnumber_equal'
.libs/ctl.o:/home/homer/work/Simpetus/libctl/src/ctl.c:323: first defined here

Probably your intention was either

(a) delete the lines in question from ctl.c, or (b) omit ctl-math.c from libctl_la_SOURCES in src/Makefile.am?

@oskooi @christopherhogan

stevengj commented 7 years ago

My intention was to delete those lines from ctl.c, sorry; will fix shortly.