NanoComp / libctl

Guile-based library implementing flexible control files for scientific simulations
GNU General Public License v2.0
19 stars 22 forks source link

Center calculation of the prism when height is defined though python as inifinity #63

Closed Yaraslaut closed 3 months ago

Yaraslaut commented 2 years ago

Initial issue: https://github.com/NanoComp/meep/issues/2144 Previously, half of the height of the prism along prism axis was added to the center in python interface during prism initilization, this caused incorrect behaviour when custom center of the prism was specified in 2d case, this PR fixes it : https://github.com/NanoComp/meep/pull/2188 while it alone should resolve the issue, another inconsistency arise from the fact that libctl also checking center of the prism and then shifts the vertices if calculated center of the prism does not coincide with defined center of the prism.