search

NanoComp / meep

free finite-difference time-domain (FDTD) software for electromagnetic simulations
GNU General Public License v2.0
1.19k stars 610 forks source link

reduce unfilter design test file size #2543

Closed mochen4 closed 1 year ago

mochen4 commented 1 year ago

Fixes #2542 . Reduced the size of files for the unfilter_design gold master test.

oskooi commented 1 year ago

The size of the updated data files in this PR are ~180 kB each. Is it possible to reduce them to below 100 kB? Alternatively, why is it necessary that the design grid be so large to validate this feature?

mochen4 commented 1 year ago

The size of the updated data files in this PR are ~180 kB each. Is it possible to reduce them to below 100 kB? Alternatively, why is it necessary that the design grid be so large to validate this feature?

I further reduced the files to about 50kb each. The design grid is now 60 by 100. I didn't want the grid to be too small because I wanted to use some nontrivial design to validate the feature.