Replace custom loops for im/r update of `step_db.cpp` with `LOOP_OVER_VOL_OWNED0`

NanoComp / meep

free finite-difference time-domain (FDTD) software for electromagnetic simulations

GNU General Public License v2.0

1.19k stars 610 forks source link

Replace custom loops for im/r update of `step_db.cpp` with `LOOP_OVER_VOL_OWNED0` #2585

Closed oskooi closed 1 year ago

oskooi commented 1 year ago

Following a suggestion by @stevengj in #2538 (comment) which had #2583 as a prerequisite, this PR replaces the eight separate custom loops for the $+im/r$ update of step_db.cpp with LOOP_OVER_VOL_OWNED0.

oskooi commented 1 year ago

This is working now and should be ready to merge.

oskooi commented 1 year ago

The pre-commit failure is not related to this PR since the logs indicate that the problem is with the notebooks in the example folder. Also, I was not able to reproduce the pre-commit failures on the my local machine by running pre-commit run --all-files per instructions in the logs. I think we can therefore ignore these errors.