search

NanoComp / meep

free finite-difference time-domain (FDTD) software for electromagnetic simulations
GNU General Public License v2.0
1.16k stars 596 forks source link

Add type checking for `frequencies` argument of `OptimizationProblem` constructor #2747

Closed oskooi closed 6 months ago

oskooi commented 6 months ago

Completes a TODO item left as a comment in python/adjoint/optimization_problem.py.

codecov-commenter commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5494b9b) 74.06% compared to head (63f69fa) 74.06%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2747 +/- ## ======================================= Coverage 74.06% 74.06% ======================================= Files 18 18 Lines 5395 5399 +4 ======================================= + Hits 3996 3999 +3 - Misses 1399 1400 +1 ``` | [Files](https://app.codecov.io/gh/NanoComp/meep/pull/2747?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [python/adjoint/optimization\_problem.py](https://app.codecov.io/gh/NanoComp/meep/pull/2747?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHl0aG9uL2Fkam9pbnQvb3B0aW1pemF0aW9uX3Byb2JsZW0ucHk=) | `59.79% <83.33%> (+0.31%)` | :arrow_up: |