search

NanoComp / meep

free finite-difference time-domain (FDTD) software for electromagnetic simulations
GNU General Public License v2.0
1.16k stars 596 forks source link

Dielectric for Au using JC values #2750

Closed kombatEldridge closed 6 months ago

kombatEldridge commented 6 months ago

Thank you for all the work you have put into meep!

Do the JC values for Au in materials.py need to have a range of wavelength values for where it is valid? Right now, it does not have a range but the two other Au fitting values have a wavelength range.

oskooi commented 6 months ago

The wavelength range for Au_JC_visible in materials.py is [400, 800] nm as the fitting data is from D. Barchiesi and T. Grosges, J. Nanophotonics, Vol. 8, 08996 (2015) as well this errata.

However, the definition of the Au_JC_visible object is missing assignment of its valid_freq_range property:

https://github.com/NanoComp/meep/blob/7c9d2083d391b7b79310755bf9c92445c74d5d95/python/materials.py#L720

Thanks for catching this bug. The fix would require adding valid_freq_range=metal_visible_range. Feel free to submit a PR with this change.

oskooi commented 6 months ago

Fixed by #2751.