Closed oskooi closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
9cc041e
) 73.78% compared to head (62ea453
) 73.79%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Note: I used this PR along with the one-line change in mpb.cpp
in #2285 to verify the accuracy of the adjoint gradients for the EigenmodeCoefficient
objective function using the 2d test involving a 1d binary grating described in #2054 (comment). After this PR and #2285 are merged, we may therefore add the 1d diffraction grating as a new unit test for the adjoint solver.
LGTM.
Fixes #2755.