search

NanoComp / meep

free finite-difference time-domain (FDTD) software for electromagnetic simulations
GNU General Public License v2.0
1.16k stars 594 forks source link

Various tweaks and minor fixes to tutorial for derivative of shape parameters #2856

Closed oskooi closed 6 days ago

oskooi commented 6 days ago

Several improvements to the recently added Tutorial/Derivatives with Respect to Shape Parameters.

codecov-commenter commented 6 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.53%. Comparing base (f29a8c7) to head (91cdd16). Report is 23 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation: There is a different number of reports uploaded between BASE (f29a8c7) and HEAD (91cdd16). Click for more details.

HEAD has 4 uploads less than BASE | Flag | BASE (f29a8c7) | HEAD (91cdd16) | |------|------|------| ||5|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2856 +/- ## =========================================== - Coverage 73.81% 61.53% -12.29% =========================================== Files 18 18 Lines 5423 5428 +5 =========================================== - Hits 4003 3340 -663 - Misses 1420 2088 +668 ``` [see 12 files with indirect coverage changes](https://app.codecov.io/gh/NanoComp/meep/pull/2856/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)