NanoComp / photonics-opt-testbed

testbed problems for photonics optimization
MIT License
27 stars 19 forks source link

Add waveguide mode converter readme, schematic diagram, design patterns, and script #11

Closed ianwilliamson closed 2 years ago

ianwilliamson commented 2 years ago

First step in tackling #6. Specifically, this PR adds a readme to document the parameters and add a schematic for the waveguide mode converter. This is based on the results from our paper.

stevengj commented 2 years ago

Great, thanks! Can you also add a CSV file for data of the the optimized structure, or will that be a separate PR?

ianwilliamson commented 2 years ago

Great, thanks! Can you also add a CSV file for data of the the optimized structure, or will that be a separate PR?

Yes, will follow up with additional PRs for (1) code to run the simulations and (2) the design patterns.

stevengj commented 2 years ago

Thanks for adding the CSV files; are these documented in the README?

ianwilliamson commented 2 years ago

Thanks for adding the CSV files; are these documented in the README?

Not yet. Will take a stab at documenting them and adding a script for running the simulations.

For FOM / optimization objective, I am thinking that we can report worst case transmission over the bandwidth of interest. I will have the script print this out.

ianwilliamson commented 2 years ago

Will take a stab at documenting them and adding a script for running the simulations.

For FOM / optimization objective, I am thinking that we can report worst case transmission over the bandwidth of interest. I will have the script print this out.

Documentation has been added. I also add the script for reporting the performance metrics.

A follow up step will be to have the script run the ruler on the designs, but currently this is not possible as the ruler.py script is not setup to be imported as a Python module. It also seems like there is a copy of ruler.py under the meta lens module.