search

NanoComp / photonics-opt-testbed

testbed problems for photonics optimization
MIT License
27 stars 19 forks source link

Tweak mode_converter_meep_opt.py #57

Closed mawc2019 closed 1 year ago

mawc2019 commented 1 year ago

The meep script mode_converter_meep_opt.py is incompatible with the latest versions of meep because of the correction. To fix this issue, in this PR, the design resolution is decreased from 100 to 99.375, and the expressions of Nx and Ny are supplemented with +1.

stevengj commented 1 year ago

I don't quite see the problem being solved here, other than the fact that the design_region_resolution variable is technically not quite a "resolution" (though it is within 1%).

Update: okay, the problem is that the filter code needs to recalculate the material-grid size (grr).

mawc2019 commented 1 year ago

Your revision is correct. This PR can be merged.