Adding 418 as a valid status code.

NanoHttpd / nanohttpd

Tiny, easily embeddable HTTP server in Java.

http://nanohttpd.org

BSD 3-Clause "New" or "Revised" License

6.94k stars 1.69k forks source link

Adding 418 as a valid status code. #544

Closed praserocking closed 5 years ago

praserocking commented 5 years ago

Justification here, https://tools.ietf.org/html/rfc7168#section-2.3.3

coveralls commented 5 years ago

Coverage increased (+0.008%) to 85.189% when pulling 29ffd3fba9add5f670ce1200e919559e0f51e24c on praserocking:master into b04a342a4bcd0ff44be65138acffc73a29381c72 on NanoHttpd:master.

LordFokas commented 5 years ago

I'm not sure if I should scold you for using an april fools RFC as a justification for adding a joke HTTP error or if I should just accept it for catalog completion reasons even though we lack many more important status codes.

praserocking commented 5 years ago

Thank you, I will work on adding all important status codes as next PR.