search

NanoMeow / QuickReports

Quick issue reports manager
GNU General Public License v3.0
15 stars 4 forks source link

metacritic.com #1640

Open NanoMeow opened 5 years ago

NanoMeow commented 5 years ago

Basic Information

Test link: https://www.metacritic.com/g00/?i10c.encReferrer=aHR0cHM6Ly93d3cubWV0YWNyaXRpYy5jb20v Category: breakage Reported from: Germany Template version: 2

User Environment

Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36 Extension: Nano Defender 15.0.0.158

Additional Message

Images of all images are blocked.

jspenguin2017 commented 5 years ago

@okiehsch Looks like the IL defuser in uBO-Extra isn't effective anymore.

okiehsch commented 5 years ago

I know, uBO-extra does not work with sites using Instart Logic's newest version. Quote from gorhill:

I do not have time to investigate what can be done, if anything. If people just want to read the articles, disabling JavaScript works on my side, so that would be the best advice we can give now.

I know Nano has uBO-extra built-in, so you should consider updating or removing it because it will break a lot of sites, sorry to say.

jspenguin2017 commented 5 years ago

Eh... That's unfortunate. I'll disable it in the next release. The current release is stuck in review...

mapx- commented 5 years ago

||metacritic.com^$inline-script

liamengland1 commented 5 years ago

How does IL work? (I know it has something to do with disguising third-party ad requests as first-party) How did they break the current defuser?

jspenguin2017 commented 5 years ago

It's some sort of server-side rendering. The current defuser looks at inline scripts being executed and stop the bootstrapper from running if some fingerprints matches. Honestly I'm surprised the defuser lasted so long.

liamengland1 commented 5 years ago

Instart Logic: www.goal.com, ign.com, ranker.com, baggersmag.com

This may be of some use if per-site fixes have to be applied temporarily: https://certdb.com/search/index?q=organization%3A%22Instart+Logic%2C+Inc%22

liamengland1 commented 5 years ago

On www.goal.com and ranker.com, Instart seems to be absent. Maybe they took it out of prod.

It's still present on IGN and baggersmag.com.

okiehsch commented 5 years ago

baggersmag.com still uses an old Instart version on my end and uBO-extra still works fine on that site.

image

ranker.com and goal.com still have Instart Logic code on my end. I can fix ranker.com with a filter in uAssets. https://github.com/uBlockOrigin/uAssets/commit/6ebff8f77a26054dc450345d030565de94a7f4e8 You need to delete cookies and bypass the cache one time for the filter to work.

liamengland1 commented 5 years ago

why not add /i10c/ to Easylist or something?

okiehsch commented 5 years ago

That would completely break the sites after redirection. Add that filter, go to metacritic.com and allow the inline-script to run. image