search

NanoMeow / QuickReports

Quick issue reports manager
GNU General Public License v3.0
15 stars 4 forks source link

twitter.com #3931

Open NanoMeow opened 4 years ago

NanoMeow commented 4 years ago

Basic Information

Test link: https://twitter.com/candicebroce Category: ads Reported from: Canada Template version: 2

User Environment

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36 Extension: Nano Adblocker 1.0.0.147

Additional Message

https://github.com/NanoMeow/QuickReports/issues/2537#issuecomment-633133584

Also on home screen when logged in.

jspenguin2017 commented 4 years ago

@llacb47 I opened another issue for the remaining placeholder spacing. Looks quite hard to fix... I wish there is :previous-sibling or something... Any filter suggestions?

liamengland1 commented 4 years ago

@llacb47 I opened another issue for the remaining placeholder spacing. Looks quite hard to fix... I wish there is :previous-sibling or something... Any filter suggestions?

Change 

twitter.com##div[aria-label*=" - "]>div[style^="padding-"]>div[style^="padding-"]>div:has(article)+div:has(>div>div:empty):not(+div+div:has(h2[role="heading"]))

to

twitter.com##h1[role="heading"]+div[aria-label]>div[style^="padding-"]>div[style^="padding-"]>div:has(article)+div:has(>div>div:empty):not(+div+div:has(h2[role="heading"]))
jspenguin2017 commented 4 years ago

This is getting way too complex. I think combining :upward and (the unimplemented) :sibling, this should be an easy fix.

So I think I'll implement :sibling instead.

gwarser commented 4 years ago

Xpath preceding-sibling?

jspenguin2017 commented 4 years ago

I have been thinking about this last night, and I think I'll instead do something like :siblings(-1,0,1) which hides the 3 elements at the same time. This avoid the need to execute the complex matching rule 3 times.

gwarser commented 4 years ago

You may also take a look at this https://www.reddit.com/r/uBlockOrigin/comments/fx3l05/rule_with_hastext_stop_working_after_some_time/

@gorhill proposed :rightward(...) for sibling operator.

jspenguin2017 commented 4 years ago

For upward, it does not make sense to select multiple elements in the chain. But for selecting siblings, there are cases (for example, this issue) where it makes sense to select multiple siblings at the same time.

gorhill commented 4 years ago

At first sight at the code, I don't think it would be difficult to support an add-to modifier to existing operators, for example:

#toto:+rightward(...):+leftward(...)

By default operators transpose one set into another, but we could have a + modifier to add to the current set instead of discarding and replacing with the result of transposition.

What I like with rightward is that it's more narrowly defined so the parsing of argument does not grow complicated, just like upward() I saw it as taking a integer (actually I remember considering a span) or a selector.

NanoMeow commented 4 years ago

Basic Information

Test link: https://twitter.com/notifications Category: breakage Reported from: Germany Template version: 2

User Environment

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36 Extension: Nano Adblocker 1.0.0.148

Additional Message

NanoMeow commented 4 years ago

Basic Information

Test link: https://twitter.com/home Category: breakage Reported from: Canada Template version: 2

User Environment

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 Extension: Nano Adblocker 1.0.0.148

Additional Message

jspenguin2017 commented 4 years ago

For https://github.com/NanoMeow/QuickReports/issues/3931#issuecomment-636573490 and https://github.com/NanoMeow/QuickReports/issues/3931#issuecomment-636573516 : Can't reproduce breakage.

NanoMeow commented 3 years ago

Basic Information

Test link: https://twitter.com/FordFischer/status/1279669245064994816 Category: breakage Reported from: United States Template version: 2

User Environment

Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.89 Safari/537.36 Extension: Nano Adblocker 1.0.0.152

Additional Message

Video doesn't play

jspenguin2017 commented 3 years ago

For https://github.com/NanoMeow/QuickReports/issues/3931#issuecomment-660570439 : Can't reproduce breakage, the video plays fine for me.

NanoMeow commented 3 years ago

Basic Information

Test link: https://twitter.com/ Category: other Reported from: Germany Template version: 2

User Environment

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0 Extension: Nano Defender 15.0.0.201

Additional Message

Original URL: https://github.com/NanoMeow/QuickReports/issues

Content Security Policy: Ignoring “'unsafe-inline'” within script-src or style-src: nonce-source or hash-source specified
[Nano] Nano Defender Activated :: twitter.com core.js:43:24
[Nano] Excluded :: All Generically Applied Solutions rules-common.js:244:28
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”). onloadwff.js:71:798525
Content Security Policy: Ignoring “'unsafe-inline'” within script-src or style-src: nonce-source or hash-source specified
Content Security Policy: The page’s settings blocked the loading of a resource at eval (“script-src”).
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”). common.js:2:319
Content Security Policy: Ignoring “'unsafe-inline'” within script-src or style-src: nonce-source or hash-source specified 2
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”). 2 core.js:214:33
Uncaught TypeError: window.__SCRIPTS_LOADED__ is undefined
    <anonymous> https://abs.twimg.com/responsive-web/web_legacy/polyfills.b0114665.js:1
polyfills.b0114665.js:1:1
Uncaught TypeError: window.__SCRIPTS_LOADED__ is undefined
    <anonymous> https://abs.twimg.com/responsive-web/web_legacy/vendors~main.94564575.js:1
vendors~main.94564575.js:1:1
Uncaught TypeError: window.__SCRIPTS_LOADED__ is undefined
    <anonymous> https://abs.twimg.com/responsive-web/web_legacy/i18n/de.72011255.js:1
de.72011255.js:1:1
Uncaught TypeError: window.__SCRIPTS_LOADED__ is undefined
    <anonymous> https://abs.twimg.com/responsive-web/web_legacy/main.7e88e4b5.js:1
main.7e88e4b5.js:1:1
Uncaught TypeError: window.__SCRIPTS_LOADED__ is undefined
    <anonymous> https://twitter.com/:106
jspenguin2017 commented 3 years ago

For https://github.com/NanoMeow/QuickReports/issues/3931#issuecomment-667426083 : Can't reproduce. @LiCybora FYI.

LiCybora commented 3 years ago

Cannot reproduce Uncaught TypeError from the test link as well, although I also get some CSP statements.

The page is working fine for me. No idea what's wrong as missing from the additional message.

NanoMeow commented 3 years ago

Basic Information

Test link: https://twitter.com/explore/tabs/covid-19 Category: other Reported from: Austria Template version: 2

User Environment

Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Firefox/68.0 Extension: Nano Adblocker 1.0.0.151

Additional Message

has banner at the bottom asking to log in