Open sradl1981 opened 7 years ago
1) Name and version of entity not matchin https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/parscale/generate-effectiveness-udf.js#L3 https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/parscale/generate-effectiveness-udf.js#L4 with this one https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/entities/eu.nanosim.parscale.effectiveReactionparameters.json
2) It is unclear where/how these two IDs are added to the collection https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/parscale/generate-effectiveness-udf.js#L24 https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/parscale/generate-effectiveness-udf.js#L25
3) this file appears useless https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/parscale/genudf.js
4) JSON files output from ParScale postprocessing tool not checked in to Porto: this will be done by Petter later (in November)
1) Name and version of entity not matchin https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/parscale/generate-effectiveness-udf.js#L3 https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/parscale/generate-effectiveness-udf.js#L4 with this one https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/entities/eu.nanosim.parscale.effectiveReactionparameters.json
2) It is unclear where/how these two IDs are added to the collection https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/parscale/generate-effectiveness-udf.js#L24 https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/parscale/generate-effectiveness-udf.js#L25
3) this file appears useless https://github.com/NanoSim/Porto/blob/porto/Preview-Final-Release/porto/examples/parscale/genudf.js
4) JSON files output from ParScale postprocessing tool not checked in to Porto: this will be done by Petter later (in November)