Nanook / NKitv1

MIT License
91 stars 22 forks source link

Fix recovery data finding on *nix #14

Open Tobiaqs opened 3 years ago

Tobiaqs commented 3 years ago

NKit does not properly find recovery data on *nix systems due to a Regex that only accepts Windows paths. This fixes that by accepting both types of slashes.

See #13 for more info.

bcomnes commented 3 years ago

I think I'm running into this issue.

bcomnes commented 3 years ago

@Tobiaqs any hints on how to build Nkit on nix with mono installed?

Tobiaqs commented 3 years ago

@bcomnes This automates what I used to build NKit on Pop_OS! You'll need Docker though, or replace the Docker step by running dotnet build in the $PWD/NKit folder.

https://gist.github.com/Tobiaqs/34420144ade5f20609bb628779b3430f

pollev commented 2 years ago

Ran in to this issue. I would like to see this added as well!

cgarz commented 2 years ago

Does this fix the crc always being 00000000? Might help #5 if so. Edit: After testing unfortunately it didn't help.

ZLima12 commented 2 years ago

I've been hitting a wall for the last hour while trying to use this tool, I had a feeling there was something wrong with the detection. This fix would be appreciated!

ZLima12 commented 2 years ago

FWIW, I was able to exploit the naive regex by renaming all the recovery files to include a backslash as the first character of their filename. After doing that, everything worked as expected.