search

Nanostring-Biostats / CellProfileLibrary

Other
23 stars 12 forks source link

Uploading 3 new Profile Matrices #8

Closed mrossNSTG closed 2 years ago

mrossNSTG commented 2 years ago

Giving this a shot! Three Lung matrices from IPF Cell Atlas: Control, IPF, COPD

maddygriz commented 2 years ago

Hey Marty. Thanks for the submission. Just a couple of metadata changes are needed before we can merge in these data sets.

  1. I have updated the tests to allow for disease states. These should be added to the Tissue name in the metadata file rather than the Profile Matrix column, allowing for easier searching in the future. For example, the Tissue = "Lung_Control" and ProfileMatrix = "Adams". This change in metadata will require a resaving of the RData file to reflect the change in the object.
  2. In the CellTypes file, the header for each sheet was not updated with the appropriate profile name. I added a test for this as well so in the future this will be caught.
maddygriz commented 2 years ago

Looks good Marty. Thanks for being the first contributor!