search

Nanostring-Biostats / GeoDiff

GeoDiff, an R package for count generating models for analyzing Geomx RNA data. Note that this version of the package is still under development, undergoing submission process to Bioconductor 3.14 release and still needs to complete NanoString internal verification process.
MIT License
7 stars 6 forks source link

merge after bioccheck() #24

Closed ned-procogia closed 2 years ago

ned-procogia commented 2 years ago

@zhiiiyang I just ran BiocCheck() - I had to change things a little bit to make it work (just a bit of syntax in my code, nothing major).

zhiiiyang commented 2 years ago

I am tagging @yangleicq to review this issue.

zhiiiyang commented 2 years ago

@rvitancol @NicoleEO, could you tell Ned what other changes are needed on specs and reqs per our discussion on standup today?

rvitancol commented 2 years ago

@ned-procogia Can you also update the Reqs and Specs and corresponding unit tests for the changes that you made? One way to check what these are is to check the following: 1. functions where Inputs and outputs were changed. 2. Functions where the calculations were changed. 3. And also add additional unit test when necessary for the code you added. Thanks.

ned-procogia commented 2 years ago

@rvitancol I will update the reqs and specs then send another pull request

zhiiiyang commented 2 years ago

@ned-procogia, a quick reminder, you don't have to close the PR every time we have any new requests. You can just keep pushing the changes in the same PR and make a comment about your changes.

ned-procogia commented 2 years ago

@zhiiiyang I didn't know that. Will bear that in mind, thanks!