search

Nanostring-Biostats / GeoDiff

GeoDiff, an R package for count generating models for analyzing Geomx RNA data. Note that this version of the package is still under development, undergoing submission process to Bioconductor 3.14 release and still needs to complete NanoString internal verification process.
MIT License
7 stars 6 forks source link

Update aggreprobe for all probenum #7

Closed NicoleEO closed 2 years ago

NicoleEO commented 2 years ago

Resolves #5 Require aggreprobe throughout and remove defaults for single probe.

All tests ran and passed. image

NicoleEO commented 2 years ago

@zhiiiyang for 2. that default value needs to stay as you can't run the score test through without probenum and in this situation the user is trying to run score test prior to aggreprobe. Are you thinking that we need to add a calc for probe num in this conditional block?

zhiiiyang commented 2 years ago

@NicoleEO, sorry, I remember it now. This line of code is just to assign value 1 to all probes so we can run score test in the probe level. It has nothing to do with the actual probe numbers for each target. Please ignore it.