Nanostring-Biostats / InSituType

An R package for performing cell typing in SMI and other single cell data
Other
22 stars 10 forks source link

Bug: get_anchor_stats() requiring `sds` when not `protein` specified #198

Closed mgrout81 closed 5 months ago

mgrout81 commented 6 months ago

I'm running get_anchor_stats() from v1.2.2 of InSituType, Built: R 4.3.1; x86_64-pc-linux-gnu; 2023-12-21 08:16:52 UTC; unix .

The function is asking me for an sds object, but the documentation says sds is only for assay_type = "protein".

> astats_old <- get_anchor_stats(counts = counts,
+                                neg = neg_means,
+                                profiles = oldprofiles)
The following genes in the count data are missing from fixed_profiles and will be omitted from downstream: CCL15,CCL18,CCL23,CCL3,CCL3L3,CCL4,CCL4L2,CCL5,CD24,CYTOR,FCGBP,FYB1,GDF10,H2AZ1,H4C3,LINC02446,MMP12,MRC1,MSMB,PECAM1,PRSS2,SELENOP,VEGFD,VSIR
Error in get_anchor_stats(counts = counts, neg = neg_means, profiles = oldprofiles) : 
  argument "sds" is missing, with no default
> astats_old <- get_anchor_stats(counts = counts,
+                                neg = neg_means,
+                                profiles = oldprofiles, assay_type = "rna")
The following genes in the count data are missing from fixed_profiles and will be omitted from downstream: CCL15,CCL18,CCL23,CCL3,CCL3L3,CCL4,CCL4L2,CCL5,CD24,CYTOR,FCGBP,FYB1,GDF10,H2AZ1,H4C3,LINC02446,MMP12,MRC1,MSMB,PECAM1,PRSS2,SELENOP,VEGFD,VSIR
Error in get_anchor_stats(counts = counts, neg = neg_means, profiles = oldprofiles,  : 
  argument "sds" is missing, with no default
>

Running with sds = NULL appears to help. Above errors printed almost immediately, while with sds = NULL has had the function running for several minutes with no errors yet.

github-actions[bot] commented 6 months ago

Thanks for your interest in our tools! Our customer support team will be able to help you with this. Please email support@nanostring.com with your issue.

Thanks, NanoString Dev Team

patrickjdanaher commented 5 months ago

fixed in upcoming 2.0 release