Nanostring-Biostats / NanoStringNCTools

Tools for NanoString Technologies nCounter Technology for reading RCC files into an ExpressionSet derived object, QC and normalization.
MIT License
9 stars 6 forks source link

Consider reformatting the apply functions #11

Open NicoleEO opened 3 years ago

NicoleEO commented 3 years ago

Per Bioconductor preferences we should switch the last sapply to at least a vapply. The issue with this is we allow the user to have any input and return type and apply as they wish across feature or sample annotations. They have accepted our package as is with the last sapply, but we should consider if there are ways to keep the flexibility whilst removing the sapply.

NicoleEO commented 3 years ago

This would require an update on anything calling esBy in other packages. Specifically remove simplify param throughout.