Nanostring-Biostats / NanoStringNCTools

Tools for NanoString Technologies nCounter Technology for reading RCC files into an ExpressionSet derived object, QC and normalization.
MIT License
9 stars 6 forks source link

Handle ggiraph new option tooltip_fill #19

Closed NicoleEO closed 3 years ago

NicoleEO commented 3 years ago

Closes #14

NicoleEO commented 3 years ago

@rvitancol can you double-check that the vignette works and looks good?

NicoleEO commented 3 years ago

@yuqiren if you have time today, can you run the vignette in today's version of this branch https://github.com/Nanostring-Biostats/NanoStringNCTools/tree/iss14-tooltip-fill, that way @rvitancol can just make sure we addressed everything Prajan wants without having to run the vignette.

yuqiren commented 3 years ago

@yuqiren if you have time today, can you run the vignette in today's version of this branch https://github.com/Nanostring-Biostats/NanoStringNCTools/tree/iss14-tooltip-fill, that way @rvitancol can just make sure we addressed everything Prajan wants without having to run the vignette.

I have run the vignette with the code in today's version of branch iss14-tooltip-fill. The html file was successfully knitted and nothing went wrong.