search

Nanostring-Biostats / NanoStringNCTools

Tools for NanoString Technologies nCounter Technology for reading RCC files into an ExpressionSet derived object, QC and normalization.
MIT License
9 stars 6 forks source link

Fix build issues with latest ggiraph version #33

Closed NicoleEO closed 1 year ago

NicoleEO commented 1 year ago

PR into Bioconductor release 3.16. Fixes issue blocking Bioconductor build.

Resolves #32

karagorman commented 1 year ago

@NicoleEO what is the reasoning for changing the errorbar_width from geomParams[["boxplot"]][["size"]] to scalingFactor?

NicoleEO commented 1 year ago

@karagorman geomParams[["boxplot"]][["size"]] no longer has a default value with the latest ggiraph update causing an error. We could do something else like set a different value or not set anything at all. What's your preference?

karagorman commented 1 year ago

@NicoleEO got it, thanks for the clarification! I figured there was a reason but it was immediately obvious so I just wanted to check. No need to change it