Nanostring-Biostats / SpatialDecon

The SpatialDecon library implements the SpatialDecon algorithm for mixed cell deconvolution in spatial gene expression datasets. (This algorithm also works in bulk expression profiling data.)
MIT License
33 stars 8 forks source link

Update deconLNR to be compatible with logNormReg v0.4.0 #21

Closed maddygriz closed 1 year ago

maddygriz commented 3 years ago

logNormReg was updated to v0.4.0 10/12/2021 and breaks our unit tests. SpatialDecon version v1.3 requires logNormReg <= v0.3.

Here is the NEWS update from logNormReg. The most likely updates that change our calculation are bolded.

version 0.4.0

maddygriz commented 3 years ago

According to Vito (author of logNormReg) the weights are the main driving issue between versions

NicoleEO commented 2 years ago

@maddygriz can you add a note in the News file re: future updates?

maddygriz commented 2 years ago

package was updated to 0.5.0 (2021-11-08)

DSPDA has updated version of logNormReg causing differences between package and plugin results.

image

maddygriz commented 1 year ago

Fixed in v1.7.3