Nanosync / pe

0 stars 0 forks source link

Suggestion feature keeps popping up when entering command and command does not execute #1

Open Nanosync opened 4 years ago

Nanosync commented 4 years ago

Justification: The command entered doesn't get processed instantly.

Steps to reproduce:

  1. Press TAB
  2. Type listexpense
  3. Press enter
  4. The command does not appear to be entered or does not disappear, the text box appears stuck. In some cases, the suggestion box reappears.

image.png

nus-pe-bot commented 4 years ago

Team's Response

I am unable to reproduce the command not being executed as described in the report. I have also not been able to reproduce any delay.

listexpense appears to behave as intended from the screenshot you have provided. It should bring you to the Expense List panel which the screenshot shows, so I see no issue with the command not executing.

When the suggestion feature is enabled (pressed TAB key, green border around command box) and the command box is empty the suggestion menu shows all possible commands. So after executing a command and when the command box is cleared, the suggestion menu will once again show all possible commands. To not show the suggestion menu, the feature can be disabled by pressing the TAB key again.

The command box only clears itself upon successful execution of a command (similar to Address Book 3 behaviour). When the command box is cleared, all the commands match the input (blank), then the suggestion menu shows. As such observation that a command does not execute does not make sense.

As for delay between pressing enter and the command finishing execution I am unable to reproduce this either.

While the behaviour of the suggestion menu is not mentioned explicity in the User Guide. However, I feel that this behaviour does not require explanation in the User Guide. More detailed behaviour about when the suggestion menu appears is documented in the Developer Guide in the activity diagram in figure 21.

Rejecting this bug.

The reported behaviour is similar to #1615

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response.

As the behaviour of the suggestion menu is not explicitly mentioned, I would like to add that is not mentioned anywhere in the user guide or developer guide that the user has to press Enter twice to execute a command with the suggestion feature on. However, if you press Enter three/four times in succession very quickly, the large suggestion box may or may not appear. This is inconsistent behaviour.

I had the impression that pressing Enter once would instantly execute the command, because this seemingly unintended behaviour appears to be a bug and makes MooLah look unresponsive.

Attached are a few gifs indicating the problem described. The start point of both gifs are when the application is first launched:

With suggestion feature (user needs to press Enter twice - pressed once upon finishing typing, but no response, so pressed again - undocumented behaviour, note that here the suggestion box is not recorded as part of the gif to show the undocumented behaviour.): MooLah_EnterTwice_SuggestionFeature.gif

According to the developer guide, I should not be required to confirm my choice as the command is already fully entered. Also, no suggestion list is showing.

The behaviour is different below:

Without suggestion feature (user presses Enter once - normal behaviour): MooLah_EnterOnce_NoSuggestionFeature.gif

The command is executed instantaneously upon pressing Enter.

Suggestion box normal behaviour (if Enter is pressed with a delay in between): MooLah_Suggestion_Reappear.gif

Suggestion box no show behaviour (if Enter is pressed rapidly - did not restart app here, need TAB to show again): MooLah_Suggestion_NoShow.gif

It is also mentioned in the target user profile of the product scope under the developer guide that the user can type fast. So this demonstrates a typical case scenario that could happen to many fast typers using MooLah.

I hope this bug can be fixed, and therefore I do not agree that the issue should be rejected.