search

NanowarOfSteel / HelloWorld

809 stars 41 forks source link

Fix nullPointerException #7

Closed Erkigmo closed 2 days ago

Erkigmo commented 2 days ago

This gets rid of the nullPointerException bug, making the code a lot more 'secure and portable,' so you can run it everywhere without crashing the code. The nullPointerException still is outputed, but it is done so without causing the program flow to halt.

DanySK commented 2 days ago

You should never catch generic exceptions. To be honest, you should never catch NPEs either, these should be dealt with by fixing your programming errors.

In this case, though, the code is bidirectionally linked to the song, and the song has been recorded. I think this PR can't get merged anyway.

NanowarOfSteel commented 2 days ago

As @DanySK said. The nullpointer is part of the song, so we cannot merge this. sorry. :D