search

Nanxi-Huang / pe

0 stars 0 forks source link

Error Messag Does Not Match Error #1

Open Nanxi-Huang opened 3 years ago

Nanxi-Huang commented 3 years ago

expected error message for delete INDEX (index is larger than the size of contact list) and delete INDEX (index is larger than MAX_INTEGER for Integer.ParseInt()) to be the same but the former shows an invalid index message and the latter shows an invalid command format message.

Screenshot 2021-04-16 at 2.38.59 PM.png

Screenshot 2021-04-16 at 2.39.35 PM.png

nus-pe-bot commented 3 years ago

Team's Response

Accepted as very low as issues does not affect usage and is only text based bug.

  1. 9999 is a invalid index (as it is bigger than the size of the contact list)
  2. Index more than max int is accepted as a bug as error message is incorrect.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: According to the CS2103T website, bugs of severity.Verylow are the ones that are purely cosmetic and do not affect usage e.g., a typo/spacing/layout/color/font issues in the docs or the UI that don't affect usage.

And in this case, the bug is not a typo/spacing/layout/color/font issue, and hence the severity should at least be severity.low, instead of the team's choice.

In addition, the error msgs for index are also different for integer larger than the size of the contact list and Index 0.

This shows that the team probably did not consider much about boundary values during their testing of the product.