search

Nanxi-Huang / pe

0 stars 0 forks source link

Error Messag Does Not Match Error (show, delete, select) #5

Open Nanxi-Huang opened 3 years ago

Nanxi-Huang commented 3 years ago

Error message for index that are larger than the size of list and index that are too large to parse should be the same ("invalid index"). However, the former shows "invalid index" and the latter shows "invalid command format index"

nus-pe-bot commented 3 years ago

Team's Response

Relabeled severity to very low due to it being a textual error that does not affect functionality.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error Messag Does Not Match Error

expected error message for delete INDEX (index is larger than the size of contact list) and delete INDEX (index is larger than MAX_INTEGER for Integer.ParseInt()) to be the same but the former shows an invalid index message and the latter shows an invalid command format message.

Screenshot 2021-04-16 at 2.38.59 PM.png

Screenshot 2021-04-16 at 2.39.35 PM.png

[original: nus-cs2103-AY2021S2/pe-interim#2818] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted as very low as issues does not affect usage and is only text based bug.

  1. 9999 is a invalid index (as it is bigger than the size of the contact list)
  2. Index more than max int is accepted as a bug as error message is incorrect.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: As described in the CS2103T website, a bug of serverity.VeryLow is a flaw that is purely cosmetic and does not affect usage e.g., a typo/spacing/layout/color/font issues in the docs or the UI that doesn't affect usage.

In this case, the bug is not about typo, spacing, layout or color, and hence should be at least severity.Low

In addition, INDEX 0, INDEX > size of the list also show different error messages. This shows that the team probably did not test the product against boundary values.