NaomiProject / Naomi

The Naomi Project is an open source, technology agnostic platform for developing always-on, voice-controlled applications!
https://projectnaomi.com/
MIT License
242 stars 47 forks source link

Record voice and playback not working during initial setup #374

Closed aaronchantrill closed 1 year ago

aaronchantrill commented 1 year ago

Description

During the initial setup process, there is an option to record your voice and play it back as part of the output device setup process. This allows users to test if their microphone is set up correctly, and preview how what they say might sound to Naomi. This appears to be broken.

Expected Behavior

After selecting an output device, if the user answers "yes" to the question "Would you like me to test your selection by recording your voice and playing it back to you?" They should be prompted to speak into the microphone. Then the VAD visualization should pop up to show the volume being received by the microphone. When a block of audio has been recorded, it gets played back so the user can verify that they can hear and understand their own words.

Actual Behavior

Instead, the interface just moves on to the next question.

Possible Fix

This is happening because I am using the "output" visualization to print the "Please speak into the mic" message. This visualization wants to print a timestamp before the output, because I am mostly using it to print the transcript of audio heard and said by Naomi. To get the timestamp, it is using the timezone setting, which is only set when setting up the "clock" plugin. Since this doesn't exist when you are first setting up Naomi, the visualization fails and knocks the user into the next question. The fix would be to pass a "timestamp=False" parameter to the function so it does not try to print a timestamp, and possibly just using the current system time instead of the timezone Naomi is using.

Steps to Reproduce

  1. Fresh install of Naomi, or at least delete your profile.yml file.
  2. Run Naomi with the --repopulate flag
  3. After setting the input device, answer "yes" to the question "Would you like me to test your selection by recording your voice and playing it back to you?"
  4. Observe that you are now being asked to select a voice activity detector plugin.

Context

I'm just trying to set up Naomi. It's not a major bug, just a little surprising.

Your Environment

aaronchantrill commented 1 year ago

Fixed in "Fix record and playback during install" #376