search

Napp / xray-laravel

AWS X-Ray tracing for Laravel apps
MIT License
56 stars 34 forks source link

Update DatabaseQueryCollector.php #28

Closed Gavrisimo closed 1 year ago

Gavrisimo commented 1 year ago

Related issue: https://github.com/Napp/xray-laravel/issues/24

viezel commented 1 year ago

Thanks for the contribution. But why would we accept null as a binding?

Gavrisimo commented 1 year ago

Thanks for the contribution. But why would we accept null as a binding?

All I did was I got this package installed and enabled all of the metrics, including db_bindings.

This was done in a Laravel project and I was getting errors in bugsnag related to things like php artisan migrate command, which is default command from Laravel. What I mean it's not like I did anything with the command and gave it null bindings and then this error showed up... :) CleanShot 2022-12-03 at 09 20 54@2x

viezel commented 1 year ago

Got it. Thanks.