search

Napster / napster.js

Napster Javascript SDK
MIT License
56 stars 44 forks source link

If cookies disabled, JS SDK fails to load with no notification to calling client #19

Closed cleio closed 5 years ago

cleio commented 5 years ago

Check if localStorage or cookies are disabled on Napster.js initialization.

BreaGaudioso commented 5 years ago

@cleio Can you have Nikola do a quick code review here before we merge it in? I just added him to the sdk devs list.

NikolaSmrcek commented 5 years ago

@cleio Looks fine to me.

@BreaGaudioso

Looks fine for me. But im not sure is it okay that we write that there is error in html. Do we want it that way? Or maybe only alert? Or maybe only in console?

Asking since i as developer would only like to be seen in console, but i got impression from the ticket that MA wants more then that.

Should be merged after streaming-player.

NikolaSmrcek commented 5 years ago

@cleio @BreaGaudioso Nevermind my mistake. That's in our example client.html

Giving thumbs up for merge. Waiting on steraming-player.