search

Napster2210 / ngx-spinner

A library for loading spinner for Angular 4 - 17.
https://napster2210.github.io/ngx-spinner/
MIT License
823 stars 138 forks source link

fix: peerDependencies require min angular >=15 #261

Closed DominicWrege closed 1 year ago

DominicWrege commented 1 year ago

Currently this package can not be used in an Angular 16 projects because the peerDependencies are not updated. This PR should provide a fix.

Error during npm install:

npm ERR! Found: @angular/common@16.0.2 npm ERR! node_modules/@angular/common npm ERR! @angular/common@"^16.0.2" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @angular/common@"^15.0.0" from ngx-spinner@16.0.0 npm ERR! node_modules/ngx-spinner npm ERR! ngx-spinner@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Napster2210 commented 1 year ago

This has been done in the latest version v16.0.2