Narfss / ParallaxEverywhere

Parallax everywhere is a library with alternative android widgets with parallax effects.
MIT License
715 stars 96 forks source link

PEWImageView to minSdkVersion=7 #1

Closed alexodus closed 9 years ago

alexodus commented 9 years ago

Hi, this is my simple modification to port PEWImageView to minSdkVersion=7 (I tested it on Gingerbread, API Level 10). I fixed the wrong initialization of listeners: they must be initialized / destroyed on onAttachedToWindow/ onDetachedFromWindow events, not in constructors. If this PR is OK, you can change, in the same way, PEWTextView. Bye

Narfss commented 9 years ago

Thanks for the request, I will update PEWTextView and the gradle as soon I test it.

Narfss commented 9 years ago

About the minsdk version, current PEWTextView implementation needs 14.

alexodus commented 9 years ago

What's the API that requires level 14?

2014-12-15 8:39 GMT+01:00 fmSirvent notifications@github.com:

About the minsdk version, current PEWTextView implementation needs 14.

— Reply to this email directly or view it on GitHub https://github.com/Narfss/ParallaxEverywhere/pull/1#issuecomment-66958706 .

Narfss commented 9 years ago

PEWTextView.java setScrollY(int) and setScrollX(int) http://developer.android.com/reference/android/view/View.html#setScrollY%28int%29

alexodus commented 9 years ago

The same situation is on PEWImageView. You can use my custom setMyScroll{X/Y} (see PEWImageView).

2014-12-15 11:48 GMT+01:00 fmSirvent notifications@github.com:

PEWTextView.java setScrollY(int) and setScrollX(int)

http://developer.android.com/reference/android/view/View.html#setScrollY%28int%29

— Reply to this email directly or view it on GitHub https://github.com/Narfss/ParallaxEverywhere/pull/1#issuecomment-66977278 .

Narfss commented 9 years ago

Sorry, I didn't see it the first time. It's the solution that I was thinking.

I'm updating the library with the new minsdk 7. Thanks.

alexodus commented 9 years ago

That's a pleasure

2014-12-15 12:10 GMT+01:00 fmSirvent notifications@github.com:

Sorry, I didn't see it the first time. It's the solution that I was thinking.

I'm updating the library with the new minsdk 7. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/Narfss/ParallaxEverywhere/pull/1#issuecomment-66979726 .