search

Narrat / Pim

PyGObject based image viewer with vim-like keybindings
MIT License
28 stars 9 forks source link

Latest deprecations #24

Closed Narrat closed 3 years ago

Narrat commented 5 years ago 
$  pim .
/usr/bin/pim:429: DeprecationWarning: Gdk.Screen.width is deprecated
  self.Sizes['sWidth'] = screen.width()
/usr/bin/pim:430: DeprecationWarning: Gdk.Screen.height is deprecated
  self.Sizes['sHeight'] = screen.height()
/usr/bin/pim:450: DeprecationWarning: Gtk.Widget.modify_bg is deprecated
  viewport.modify_bg(Gtk.StateType.NORMAL, Gdk.color_parse('#999999'))
/usr/bin/pim:388: DeprecationWarning: Gdk.Cursor.new is deprecated
  self.win.get_window().set_cursor(Gdk.Cursor.new(Gdk.CursorType.BLANK_CURSOR))
Narrat commented 4 years ago

Regarding the cursor: Hopefully addressed with https://github.com/Narrat/Pim/commit/185fd2a006b63c09fec5b4845cacb82a8142c409

Narrat commented 4 years ago

Dunno about the background deprecation. Either replacement requires more work, than I'm currently want to invest. https://lazka.github.io/pgi-docs/Gtk-3.0/classes/Widget.html#Gtk.Widget.override_background_color (was direct replacement for modify_bg)

Narrat commented 4 years ago

Deprecations regarding Gdk.Screen is addressed with https://github.com/Narrat/Pim/commit/6682138c32f4b62d369d623a21b5dab0cb203e61 This bumps the required pygobject version to 3.22 and doesn't respect multi monitor setups