search

Nascom / TeamleaderApiClient

PHP Client to connect to the Teamleader API
MIT License
9 stars 9 forks source link

Pass content-type header to fix filters #22

Open WouterSioen opened 11 months ago

WouterSioen commented 11 months ago

I was implementing this library using the a Guzzle7 http client. When trying to do a request to companies.list with a filter, the filter did not seem to be applied.

By changing my own Guzzle Client to always pass the Content-Type header, this was fixed. This shouldn't be necessary to configure on the outside though since the library itself knows that it always sends JSON bodies. Let's thus adapt the API Client itself so that custom http clients don't have to add this header themselves.

WouterSioen commented 7 months ago

Any chance of getting this merged and released?

mark-gerarts commented 7 months ago

@BramG @wimvds this looks good to me. I don't use this library anymore, so maybe it's best if you do a quick check & merge?