Nasdaq / data-link-python

A Python library for Nasdaq Data Link's RESTful API
MIT License
428 stars 70 forks source link

Update api_config.py #15

Closed wouldayajustlookatit closed 2 years ago

wouldayajustlookatit commented 2 years ago

added the ability to pull the api key from a variable instead of the having to conduct a retrieve operation from a file. just another useful option :)

couture-ql commented 2 years ago

What's the use-case you'd like to solve for adding another keyword arg? There are three ways one can update the API Key, two of which avoid defining it in source code.

I'd prefer to avoid adding another means to set an API Key, especially one that doesn't guide you away from hard-coding the API Key in source.

couture-ql commented 2 years ago

Closing due to lack of feedback.

Happy to revisit and address any particular use-case you're looking to solve.