search

Nasdaq / semver-git

Gradle plugin that combines git tags and semantic versioning, and sets the gradle version property accordingly.
MIT License
45 stars 15 forks source link

use project dir in getGitVersion #2

Closed zombiedev closed 8 years ago

zombiedev commented 8 years ago

Rather than running git describe in the current working dir, run it in the directory of the gradle project. This allows projects that come from git submodules to use the versions from their repo's tags.

zombiedev commented 8 years ago

I have not yet signed the Cinnober CLA, but I'll send it to you soon.

mbrannstrom commented 8 years ago

Zombiedev, have you signed the CLA and heard anything from Cinnober yet?

I'm not working at Cinnober anymore but I think this should be merged and released as a bug-fix, i.e. as version 2.2.2.

zombiedev commented 8 years ago

@mbrannstrom, I just emailed it to them.

I don't know how active this project is or when they'll merge this PR, but you can always do something like this in the meantime:

buildscript {
    repositories {
        mavenCentral()
        jcenter()
        maven { url "https://jitpack.io" }
    }

    dependencies {
        classpath "com.github.zombiedev:semver-git:98f7bb63b0"
    }
}
MikaelUmaN commented 8 years ago

Thank you for your contribution. I will try to find out who are on the mailing list aforementioned and why no response was sent to you.