search

Nasdaq / semver-git

Gradle plugin that combines git tags and semantic versioning, and sets the gradle version property accordingly.
MIT License
45 stars 15 forks source link

Add option to configure via semverGit {} block #28

Open emlun opened 1 year ago

emlun commented 1 year ago

This allows the plugin to be applied with the new plugins {} DSL.

Fixes #3. Alleviates #14. Fixes #26.

deepy commented 1 year ago

Alright, I found the corner-case. It's in this project's build-script 😁 The publishing section in build.gradle needs to use version.toString() otherwise the build fails.

Could you do this change and at the same time use -s on that commit to sign-off the changes? Previously this repository required a CLA, but before I left the discussion was to replace it with DCO which is basically the same thing but with less paperwork

After that it looks good enough to be merged, I'll have to chase some people to actually get it released though so that might take some extra time