Provenance

[Nat1405]

This merge is to prepare Nifty data products for CAOM2 ingestion. This is mostly updating FITS header values, and in the case of reduced cube products, adding cal extensions that list the calibrations used.

Open questions:

• Should we archive the files used to produce the telluric correction as well, or the telluric cubes/ extracted telluric spectra?
• Ditto for the flux calibration.

[Nat1405]

Hi Sharon, thanks so much for your feedback as well. I've addressed some of your comments in 0f9c8ed, f6c8447, and 4a5d529. Much appreciated.

[Nat1405]

Hi @dbohlender, can you take a look at my three latest commits (f3f9e6c, b10d4ef, f6c8729) and let me know what you think?

f3f9e6c adds integration tests for the new provenance extension based on NIFS program GN-2014A-Q-85. b10d4ef doesn't really do much, it just fixes an integration test problem. f6c8729 adds the code that actually adds the provenance extension. Namely, it modifies the data label if there is more than one member, and creates and adds the "PROVENANCE" BINTABLE extension that contains three columns: filename, description, and type.

Let me know if you'd like a sample of what the final tagged products look like as well. Thank you!

[Nat1405]

Hi @dbohlender , thanks for your review so far. I've added some new code and would love your review.

• 090bde1 makes attributes of the CalibrationTagger class "static" so they can be accessed by the ProductTagger class. This is to avoid duplicating redundant code in both of the Tagger classes.
• 50e723f propagates darks through the pipeline. Surprisingly easy due to good design :)
• 5a55f63 fixes a few bugs, and is where we start using the processed dark rather than the raw darks in the provenance propagation.
• d1bf41d fixes a bug.
• 966fa9b works in your RONCHI comments.
• a5e4edc adds an integration test for product tagging, including making sure the sky frames are identified properly.
• ec95e64 changes the product tagger to add provenance information in an extension, rather than in a header.
• 16ab2cf Adds another integration test, and
• d7f1f6f incorporates your .upper() and readability (underscores) comments, and fixes up the integration tests.

Thanks again for your review.