NatLibFi / Annif

Annif is a multi-algorithm automated subject indexing tool for libraries, archives and museums.
https://annif.org
Other
195 stars 41 forks source link

Avoid using pytest-flake8 plugin #650

Closed juhoinkinen closed 1 year ago

juhoinkinen commented 1 year ago

Closes #599.

Unpins flake8. On my laptop version 5.0.4 get installed, while 6.0.0 was released two days ago.

In the CI/CD pipeline I added flake8 step that both installs flake8 from PyPI with pip and runs it. There version 6.0.0 get installed. I did not find a good GH Action for flake8 (an official one or any which seemed otherwise reputable), so it can be better to install it this way.

The mismatch of the versions is unfortunate, but makes no difference at this time.

Also I'm thinking that it might be a good idea to switch installing also isort and Black from PyPI (instead of using the GH Actions), and using Poetry for that (regular dependencies can be omitted by poetry install --only dev).

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 1 year ago

Codecov Report

Base: 99.54% // Head: 99.55% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (2e812ec) compared to base (1a58116). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #650 +/- ## ======================================= Coverage 99.54% 99.55% ======================================= Files 87 87 Lines 5988 6004 +16 ======================================= + Hits 5961 5977 +16 Misses 27 27 ``` | [Impacted Files](https://codecov.io/gh/NatLibFi/Annif/pull/650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NatLibFi) | Coverage Δ | | |---|---|---| | [annif/backend/http.py](https://codecov.io/gh/NatLibFi/Annif/pull/650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NatLibFi#diff-YW5uaWYvYmFja2VuZC9odHRwLnB5) | `100.00% <0.00%> (ø)` | | | [tests/test\_backend\_http.py](https://codecov.io/gh/NatLibFi/Annif/pull/650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NatLibFi#diff-dGVzdHMvdGVzdF9iYWNrZW5kX2h0dHAucHk=) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NatLibFi). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NatLibFi)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

osma commented 1 year ago

Looks very good!

Also I'm thinking that it might be a good idea to switch installing also isort and Black from PyPI (instead of using the GH Actions), and using Poetry for that (regular dependencies can be omitted by poetry install --only dev).

I think that sounds like a good idea! Would it make sense to do this change already in this PR, or a new one after this has been merged?

juhoinkinen commented 1 year ago

Looks very good!

Also I'm thinking that it might be a good idea to switch installing also isort and Black from PyPI (instead of using the GH Actions), and using Poetry for that (regular dependencies can be omitted by poetry install --only dev).

I think that sounds like a good idea! Would it make sense to do this change already in this PR, or a new one after this has been merged?

Better to make a new PR for that think, it might need some experimenting to make it work...