NatLibFi / Annif

Annif is a multi-algorithm automated subject indexing tool for libraries, archives and museums.
https://annif.org
Other
195 stars 41 forks source link

Install linting tools with Poetry in CI/CD pipeline #656

Closed juhoinkinen closed 1 year ago

juhoinkinen commented 1 year ago

As discussed in #650, this PR switches installing isort and Black from PyPI with Poetry (instead of using the GH Actions) and flake8 with Poetry, so now the versions of these tools are the same in CI/CD and in local installations (maybe depending on the Python versions in the environments; in CI/CD linting job I chose to use Python 3.10). Also this approach might be a little more secure way to install the tools as it does not rely on the GH Actions.

Downside is longer and more complex definition.

codecov[bot] commented 1 year ago

Codecov Report

Base: 99.55% // Head: 99.55% // No change to project coverage :thumbsup:

Coverage data is based on head (3632bfe) compared to base (45be34d). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #656 +/- ## ======================================= Coverage 99.55% 99.55% ======================================= Files 87 87 Lines 6006 6006 ======================================= Hits 5979 5979 Misses 27 27 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NatLibFi). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NatLibFi)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information