Closed osma closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.64%. Comparing base (
337ee70
) to head (61c9409
). Report is 8 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
In PR #796 Simplemma is updated to 1.1, so this could be merged after that.
There I already did some neccessary changes to the language detection code: https://github.com/NatLibFi/Annif/pull/796/commits/49d50520ee136dc159538f65bd3f810a0e4efae2
Rebased on current main
and force-pushed.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
This PR upgrades Simplemma to the latest version 1.1.1 and adds some wrapper code to make it possible to use Simplemma language detection with a limit on the number of languages simultaneously loaded into memory. The number of languages is currently hardcoded at 5.
This will enable adding language detection functionality to the REST API in PR #659 , which has not been merged yet due to concerns about memory usage.