Closed juhoinkinen closed 1 year ago
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
320af2b
) 99.67% compared to head (f928844
) 99.67%. Report is 18 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If the unit tests pass on Python 3.11 (except Omikuji, but that is not even installed for 3.11), then I don't see why we should mark the CI tests as experimental. It would be a different situation if some core tests were failing on 3.11 and we couldn't fix them right now.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
The Python 3.11 parts of this PR look good to me, but since this includes all the commits from PR #726, we need to make sure those are good as well before merging this. I noticed a potential problem with TF/Keras, see https://github.com/NatLibFi/Annif/pull/726#issuecomment-1680047565
Allow installing Annif on Python 3.11, and run unit tests on it in the CI/CD pipeline.
Omikuji dependency does not work Python 3.11, see https://github.com/NatLibFi/Annif/issues/703#issuecomment-1614513903. Other dependencies seem to work (i.e. the unit tests pass).
tomli
is now a (direct) dependency only on Python <3.11, on Python 3.11tomllib
of standard library is used instead (PEP 690). However, also on Python 3.11tomli
is still installed as it is a dependency ofblack
,coverage
,pytest
andschemathesis
.Closes #703, includes merge of the branch of #726.