search

NatLibFi / FintoAI

Finto AI suggests subjects for a given text. It's based on Annif, a tool for automated subject indexing.
https://ai.finto.fi
7 stars 0 forks source link

Simplify translation of terms #12

Closed UnniKohonen closed 1 year ago

UnniKohonen commented 1 year ago

This PR simplifies translation of suggested terms by using the language parameter of Annif API's suggest method. Calls to Finto API are removed.

Implements #10

juhoinkinen commented 1 year ago

Hmm, I think it's best to merge to update-2022, because that branch is deployed for ai.dev.finto.fi , and main branch for ai.finto.fi.

osma commented 1 year ago

I changed the base branch, but now we have many more commits in this PR. I think there should be a merge from main to update-2022 first that would take care of the commits that are not yet in update-2022.

juhoinkinen commented 1 year ago

I changed the base branch, but now we have many more commits in this PR. I think there should be a merge from main to update-2022 first that would take care of the commits that are not yet in update-2022.

Ok, I'll merge on my laptop and push.

juhoinkinen commented 1 year ago

To make "the extra commits" disappear from thia PR, I also had to switch the base branch to main (any other branch could have done) and back to update-2022. This was suggested in StackOverflow.

osma commented 1 year ago

:tada: