search

NatLibFi / RecordManager

A metadata record management system written in PHP, intended to be used in conjunction with VuFind or another Solr-based discovery interface. Provides import, export, harvesting (OAI-PMH), normalization, deduplication and Solr index update functionality with support for multiple metadata formats. Also includes an OAI-PMH provider that can be used to access the data stored in RecordManager database. Functionality driven by simple command line programs for easy automation.
GNU General Public License v2.0
47 stars 31 forks source link

Fix line-based leader processing in line-based MARC formatter. #100

Closed demiankatz closed 2 years ago

demiankatz commented 2 years ago

I discovered that the line-based MARC formatter had a hard-coded assumption about leaders which is not correct for the GeniePlus format, so I added another configuration setting to correct for this.

demiankatz commented 2 years ago

(I also replaced the genieplus test fixture with a longer, more complete record).

demiankatz commented 2 years ago

The plot thickens: at first, I thought this was a GeniePlus-specific bug, but then I discovered that the Alma leader was also getting mangled. I have adjusted tests and defaults to make all documented cases work correctly now... but I wonder why the default was the way it was to begin with. Was this always broken, or is there some line-based format not currently covered by tests that does require a different leader offset?