Add support for SQL databases with a PDO database class.

NatLibFi / RecordManager

A metadata record management system written in PHP, intended to be used in conjunction with VuFind or another Solr-based discovery interface. Provides import, export, harvesting (OAI-PMH), normalization, deduplication and Solr index update functionality with support for multiple metadata formats. Also includes an OAI-PMH provider that can be used to access the data stored in RecordManager database. Functionality driven by simple command line programs for easy automation.

GNU General Public License v2.0

47 stars 31 forks source link

Add support for SQL databases with a PDO database class. #55

Closed EreMaijala closed 3 years ago

EreMaijala commented 3 years ago

Includes database creation script for MySQL/MariaDB.

LuomaJuha commented 3 years ago

ERROR 1005 (HY000) at line 1 in file: '.../dbscripts/mysql.sql': Can't create table recman.record (errno: 150 "Foreign key constraint is incorrectly formed") ERROR 1005 (HY000) at line 24 in file: '.../dbscripts/mysql.sql': Can't create table recman.record_attrs (errno: 150 "Foreign key constraint is incorrectly formed") Query OK, 0 rows affected (0.033 sec)

ERROR 1005 (HY000) at line 40 in file: '.../dbscripts/mysql.sql': Can't create table recman.dedup_attrs (errno: 150 "Foreign key constraint is incorrectly formed")

Pari virhettä tuli vastaan, toimi kun ajoi toistamiseen tuon mysql.sql tiedoston

EreMaijala commented 3 years ago

@LuomaJuha Now fixed.

EreMaijala commented 3 years ago

@demiankatz Thanks for your feedback, appreciated! No static analysis tools used yet, but I'll see what I can do about that. It's a good idea! Also, splitting the database config to backend-specific sections makes sense. I'll adjust it right away.

demiankatz commented 3 years ago

Great! Let me know if I can do anything more to help. If you want to try PHPMD, you should be able to steal the Phing settings from VuFind pretty easily. You can also find Psalm setup in a PR: https://github.com/vufind-org/vufind/pull/1764. I haven't gotten around to investigating PHPStan yet.