search

NatLibFi / Skosify

Validate, convert and improve SKOS vocabularies
http://skosify.readthedocs.io/
MIT License
55 stars 8 forks source link

Deterministic skosify log #79

Closed kouralex closed 4 years ago

kouralex commented 4 years ago

This PR will continue the work done on #72 by introducing sorting functions to every possible place where logging is performed as I encountered previously unnoticed case of nondeterministic logging in https://github.com/NatLibFi/Finto-data/commit/0454157f1d4b3a799c3ffbc4d2c48f341a125234.

There may still be places that are not deterministic as I can pinpoint, for example, to https://github.com/NatLibFi/Skosify/blob/ce6441a9240ac1ac81334168e22302c93bba2c77/skosify/skosify.py#L110-L116 where the outcome is not guaranteed.

codecov-io commented 4 years ago

Codecov Report

Merging #79 (2ea7df3) into master (ce6441a) will increase coverage by 0.18%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   59.05%   59.23%   +0.18%     
==========================================
  Files          10       10              
  Lines         928      920       -8     
==========================================
- Hits          548      545       -3     
+ Misses        380      375       -5
Impacted Files Coverage Δ
skosify/infer.py 72.36% <0.00%> (ø)
skosify.py 52.71% <0.00%> (+0.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce6441a...2ea7df3. Read the comment docs.