NatLibFi / Skosmos

Thesaurus and controlled vocabulary browser using SKOS and SPARQL
Other
219 stars 94 forks source link

Concept page does not display all the properties present in the concept data #1265

Open joelit opened 2 years ago

joelit commented 2 years ago

At which URL did you encounter the problem?

https://dati.lnb.lv/onto/nllsh/lv/page/LNC10-000048639

What steps will reproduce the problem?

  1. Load the page. It will have prefLabel, foreign labels and URI as the concept info
  2. Look at the concept data in turtle (download this concept)
  3. There are several properties which should be displayed, but they don't have a string representation in the chosen UI language

The cause is possibly this: https://github.com/NatLibFi/Skosmos/blob/52e707930df8ab2bb2e8993cc7181e384cfa8163/model/Concept.php#L571

What is the expected output? What do you see instead?

https://dati.lnb.lv/onto/nllsh/en/page/LNC10-000048639 There is an attempt to retrieve a default property label, but AFAIK such cannot be determined in this case

What browser did you use? (eg. Firefox, Chrome, Safari, Internet explorer)

Chrome

CaptSolo commented 2 years ago

As we work around this issue (by providing a Latvian translation) the contents of the URLs mentioned above may change.

Here are archived versions of these webpages:

miguelvaara commented 2 years ago

.. a little bit out of context:

The concept mentioned in the issue: http://dati.lnb.lv/onto/subject/LNC10-000048639

The reason why some of the narrower concepts do not appear in the hierarchy tab is that skos:broader (LNC10-000048639) is missing.

These are not visible in the hierarchy and skos:broader is missing:

http://dati.lnb.lv/onto/subject/LNC10-000132143 "Substance (filozofija)"

http://dati.lnb.lv/onto/subject/LNC10-000048640 "Nepieciešamība (filozofija)"

http://dati.lnb.lv/onto/subject/LNC10-000048635 "Metafizika"

http://dati.lnb.lv/onto/subject/LNC10-000048176 "Filozofija"

Skos:broader and skos:narrower relations should be defined explicitly at both ends, in the broader concept and in the narrower.

osma commented 2 years ago

This is by design and documented in the Wiki on the Data Models page section on Additional custom properties. Any non-standard properties (where "standard" refers to SKOS, DC/DCT and some other well-known vocabularies) need to have an rdfs:label in the UI language(s).

If the proposal is to change this, then we should think about what to use as the property label. A rdfs:label in a different language? The localname of the property?

CaptSolo commented 2 years ago

If the proposal is to change this, then we should think about what to use as the property label. A rdfs:label in a different language? The localname of the property?

Any name would be better than not showing these properties at all.

The localname of the property is one option. Looks like that is what gets displayed for the preferred label - the UI shows text skos:prefLabel for this property.

Perhaps seeing such "technical" property names would encourage users to add proper translations :-)

osma commented 2 years ago

Any name would be better than not showing these properties at all.

I hear what you're saying, but this would be quite a change from the current status quo. My fear is that if we change this, then there will be many Skosmos installations that start showing unwanted properties for concepts. At the minimum, there should be a way to enable/disable this. And maybe also a mechanism for hiding properties that are not intended to be displayed.

osma commented 2 years ago

FYI, I also recently added an entry about this into the FAQ: https://github.com/NatLibFi/Skosmos/wiki/FAQ-and-Troubleshooting#i-have-custom-rdf-properties-in-my-skos-data-how-can-i-make-skosmos-show-them